Remove redundant STA calls in RepairDesign#10744
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the timing analysis and repair flow in RepairDesign and RepairTargetCollector. Key changes include updating performGainBuffering to accept a sta::Vertex* instead of a sta::Pin*, adding a prerequisite call to sta_->findRequired(drvr), and removing redundant incremental timing updates and arrival/required search calls. Additionally, manual loops for un-annotating slews are replaced with sta_->unsetAnnotatedSlew, and sdc_->makeExceptionTo and search_->findPathEnds are updated to use sta_ equivalents. There are no review comments, so I have no feedback to provide.
|
@codex review |
|
If the CI is ok I don't have anything to add. |
secure CI was fine. Public CI had a small variation in GRT TNS though CF TNS was fine. I created a metric PR The-OpenROAD-Project/OpenROAD-flow-scripts#4308 |
Summary
Cleans up redundant STA calls in the resizer's RepairDesign, continuing the work started in #10480
Changes
Note: this is the first of two steps. A follow-up will add findRequired inside Sta::vertexWorstSlackPath (the proper place for it), after which the explicit findRequireds/findRequired calls that remain in the resizer can be removed.
Type of Change
Impact
None
Verification
./etc/Build.sh).